[ir][refactor] First step to move Frontend IR to its own file #914

k-ye · 2020-05-03T00:39:58Z

In this PR, I just moved FrontendAllocaStmt to a new file frontend_ir.h. If this looks OK, I will move all the other Frontend*Stmt (maybe *Expression as well ?)

Related issue = #689

[Click here for the format server]

yuanming-hu

Looks good, thanks! And yes, let's move the Expressions as well. The expressions are only useful in the frontend before lower_ast. Not sure if we should create a separate file for the Expressions, but you should clearly have better judgment than I do! :-)

k-ye · 2020-05-03T00:45:29Z

Not sure if we should create a separate file for the Expressions

Cool! Not sure either, but I don't see an immediate need for separate Frontend Stmt and Expressions, so I will go with one file...

yuanming-hu · 2020-05-03T00:47:32Z

Sounds good! Given the current code structure, I don't think separating Exprs and Stmts is an easy job anyway...

k-ye · 2020-05-03T01:58:55Z

Will create another PR for the rest of the works..

xumingkuan

Thanks!

xumingkuan · 2020-05-03T18:05:47Z

taichi/ir/ir.cpp

@@ -7,6 +7,7 @@
 #include <unordered_map>

 #include "taichi/ir/frontend.h"
+#include "taichi/ir/frontend_ir.h"


Not sure if this is necessary after we move all Frontend*Stmts to their own file.

I guess they have to be around for a while, since currently there are some legacy stuff referring to the Frontend stmts, e.g.

taichi/taichi/ir/ir.cpp

Lines 933 to 941 in 4d228b9

For::For(const ExprGroup &i,

const Expr &global,

const std::function<void()> &func) {

auto stmt_unique = std::make_unique<FrontendForStmt>(i, global);

auto stmt = stmt_unique.get();

current_ast_builder().insert(std::move(stmt_unique));

auto _ = current_ast_builder().create_scope(stmt->body);

func();

}

I think once these legacy constructs are removed, then it should be fine to remove this dependency..

[ir][refactor] First step to move Frontendd IR to its own file

f41a4f0

k-ye requested review from yuanming-hu, archibate and xumingkuan May 3, 2020 00:40

yuanming-hu approved these changes May 3, 2020

View reviewed changes

k-ye changed the title ~~[ir][refactor] First step to move Frontendd IR to its own file~~ [ir][refactor] First step to move Frontend IR to its own file May 3, 2020

[skip ci] enforce code format

90974c0

k-ye merged commit ad6fcbf into taichi-dev:master May 3, 2020

k-ye deleted the f1 branch May 3, 2020 01:59

k-ye mentioned this pull request May 3, 2020

[ir][refactor] Move all frontend stmts to frontend_ir.h #916

Merged

xumingkuan reviewed May 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ir][refactor] First step to move Frontend IR to its own file #914

[ir][refactor] First step to move Frontend IR to its own file #914

k-ye commented May 3, 2020

yuanming-hu left a comment

k-ye commented May 3, 2020

yuanming-hu commented May 3, 2020

k-ye commented May 3, 2020

xumingkuan left a comment

xumingkuan May 3, 2020

k-ye May 4, 2020 •

edited

Loading

	For::For(const ExprGroup &i,
	const Expr &global,
	const std::function<void()> &func) {
	auto stmt_unique = std::make_unique<FrontendForStmt>(i, global);
	auto stmt = stmt_unique.get();
	current_ast_builder().insert(std::move(stmt_unique));
	auto _ = current_ast_builder().create_scope(stmt->body);
	func();
	}

[ir][refactor] First step to move Frontend IR to its own file #914

[ir][refactor] First step to move Frontend IR to its own file #914

Conversation

k-ye commented May 3, 2020

yuanming-hu left a comment

Choose a reason for hiding this comment

k-ye commented May 3, 2020

yuanming-hu commented May 3, 2020

k-ye commented May 3, 2020

xumingkuan left a comment

Choose a reason for hiding this comment

xumingkuan May 3, 2020

Choose a reason for hiding this comment

k-ye May 4, 2020 • edited Loading

Choose a reason for hiding this comment

k-ye May 4, 2020 •

edited

Loading